forked from zcash/librustzcash
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zupdate #20
Draft
fluidvanadium
wants to merge
151
commits into
zingolabs:main
Choose a base branch
from
fluidvanadium:zupdate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Zupdate #20
+11,459
−3,546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcash_client_sqlite: Fix incorrect input selection filtering when sending to transparent.
… have an Orchard receiver.
…t_ua zcash_client_sqlite: Add a migration to ensure that default addresses…
zcash_client_sqlite: Use named column accessors for `to_spendable_note`
zcash_client_sqlite: Fix sloppy named-parameter reference.
This implements the necessary state machine for taking a wallet in some arbitrary synchronization status, and fully scanning (the remainder of) the chain. Closes zcash#1169.
zcash_client_backend: Implement async wallet synchronization function
…addresses Prior to this change, the recipient of a sent transaction would always be shown as the protocol-level address, instead of any unified address intended as the recipient. Now, instead of reencoding the recipient address, we use the original `ZcashAddress` value from the payment request.
zcash_client_sqlite: Fix broken `account_birthday` method.
…0.10.3 Release zcash_client_sqlite version 0.10.3
Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3 to 4. - [Release notes](https://github.com/peaceiris/actions-gh-pages/releases) - [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md) - [Commits](peaceiris/actions-gh-pages@v3...v4) --- updated-dependencies: - dependency-name: peaceiris/actions-gh-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [supplypike/setup-bin](https://github.com/supplypike/setup-bin) from 3 to 4. - [Release notes](https://github.com/supplypike/setup-bin/releases) - [Commits](supplypike/setup-bin@v3...v4) --- updated-dependencies: - dependency-name: supplypike/setup-bin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…pplypike/setup-bin-4 build(deps): bump supplypike/setup-bin from 3 to 4
Cleanups, refactoring, and placeholder for TEX addresses
…ategy` now implement a different strategy for choosing whether there will be any change, and its value. The aims are: * Ensure that it is possible to create fully transparent transactions with no change (this will be needed for ZIP 320). The `InsufficientFunds` error in this case should have a `required` field that reflects the additional amount needed, according to the fee calculated without an extra change output. * Avoid leaking information about note amounts in some cases: an adversary that knew the number of external recipients and the sum of their outputs was able to learn the sum of the inputs if no change output was present. * Defend against losing money by using `DustAction::AddDustToFee` with a too-high dust threshold. * Ensure that if a "change memo" is requested, there will always be a shielded change output in which to put it. Previously, this would not be the case when using `DustAction::AddDustToFee`. Co-authored-by: Jack Grigg <[email protected]> Co-authored-by: Kris Nuttycombe <[email protected]> Signed-off-by: Daira-Emma Hopwood <[email protected]>
Improvements to the strategy implemented by `{fixed,standard,zip317}::SingleOutputChangeStrategy`
Signed-off-by: Daira-Emma Hopwood <[email protected]>
Update tests in testing/pool.rs to use ZIP 317 fees
The `foreign_keys` pragma has no effect when used within a transaction, so it should only be set at the top level. The `legacy_alter_table` pragma should only be used in cases where its effect is explicitly intended.
Co-authored-by: str4d <[email protected]>
zcash_client_sqlite: Fix handling of PRAGMA directives.
…decov/codecov-action-4.5.0 build(deps): bump codecov/codecov-action from 4.3.0 to 4.5.0
…`wallet::transparent` module.
… shielded notes. Co-authored-by: Daira-Emma Hopwood <[email protected]> Co-authored-by: Jack Grigg <[email protected]>
Co-authored-by: Jack Grigg <[email protected]> Co-authored-by: Daira-Emma Hopwood <[email protected]>
zcash_client_sqlite: Align handling of transparent UTXOs with that of shielded notes.
This reverts commit 50ffcd4.
…ddfc6b18e8fb84ea277c9 Fixes zcash#1431
…_memo move the 0-value change case into the dust case
zcash_client_backend: Fix panic related to insertion of frontiers below subtree roots.
merged function signature for calculate proposed transaction kept metadata handling deleted substituted rewritten fees/common.rs use secp256k1 keys err on tex request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.