Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya siren _TZE204_fncxk3ob variant #3545

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

FilipParyz
Copy link

Proposed change

This PR adds support for additional Siren variant and fixes issue #3180

Additional information

This is my first contribution to the ZigPy repo. I used PR #3361 as a guide how and where I should add the Siren variant. I have not tested it locally, but would be glad to do so once guided.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@FilipParyz FilipParyz changed the title Added Tuya Siren variant Add Tuya Siren TS0601 _TZE204_fncxk3ob variant Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (e5582c3) to head (1c78015).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3545   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         314      314           
  Lines       10243    10243           
=======================================
  Hits         9181     9181           
  Misses       1062     1062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). labels Nov 25, 2024
@TheJulianJES TheJulianJES changed the title Add Tuya Siren TS0601 _TZE204_fncxk3ob variant Add Tuya siren _TZE204_fncxk3ob variant Nov 25, 2024
@FilipParyz
Copy link
Author

Hi @TheJulianJES !
Do you think you'll be merging this change anytime soon? If not, what would you need from me to help with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants