Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Philips Hue wall switch RDM004 variant #3543

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Nov 25, 2024

Proposed change

Adds an additional quirk variant for the Philips Hue wall switch RDM004 based on the signature provided in #3539.

Additional information

Fixes #3539

This would have been a perfect candidate for a v2 quirk, but we'd need to convert all Philips Hue remote related tests and other Hue remote quirks to be v2 then, as mixed v1/v2 tests are a bit annoying.
We should still do this in the future.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (77c05e7) to head (e821752).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3543   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files         313      313           
  Lines       10218    10221    +3     
=======================================
+ Hits         9157     9160    +3     
  Misses       1061     1061           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TheJulianJES TheJulianJES merged commit 7e99a61 into zigpy:dev Nov 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Quirk not applied to Hue wall switch RDM004
1 participant