-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tuya Royal Gardineer irrigation valve quirk #3505
Add Tuya Royal Gardineer irrigation valve quirk #3505
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3505 +/- ##
=======================================
Coverage 89.75% 89.76%
=======================================
Files 320 320
Lines 10371 10381 +10
=======================================
+ Hits 9308 9318 +10
Misses 1063 1063 ☔ View full report in Codecov by Sentry. |
2454a60
to
30bac30
Compare
30bac30
to
73285eb
Compare
Once #3550 is merged or a variation of it, the correct power config will be available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good to me.
I've changed the power configuration cluster to TuyaPowerConfigurationCluster2AA
now. It should work in Home Assistant Core 2024.12 and later.
It won't work when used as a custom quirk in 2024.11 though.
Proposed change
Quirk for supporting Royal Gardineer valve.
Similar to this device.
Additional information
Exposes:
Valve works on a timer only, with a default timer of 10 minutes. Before opening the valve, it is recommended to set the irrigation desired time in the "Timer time left" field.
Checklist
pre-commit
checks pass / the code has been formatted using Black