Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the capnp server classes available #61

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

mommsen
Copy link
Collaborator

@mommsen mommsen commented Mar 21, 2024

Move code used for mocking the device server to its own module labone.server to make it reusable for the Python capnp servers. Remove the mention of "mock" in the exported code.

Move code used for mocking the device server to its own module
`labone.server` to make it reusable for the Python capnp servers.
Remove the mention of "mock" in the exported code.
@mommsen mommsen force-pushed the remigiusm/make_server_public branch from 7a79eed to 15167d8 Compare March 21, 2024 11:19
Copy link
Member

@tobiasah tobiasah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have one question

src/labone/server/server.py Outdated Show resolved Hide resolved
The method `start_server` allows starting the capnp server with
schema and server instance. It enables the creation of
stand-alone Python servers accepting multiple connections.
@mommsen mommsen force-pushed the remigiusm/make_server_public branch from 15167d8 to 0b3c0c5 Compare March 21, 2024 15:15
@tobiasah tobiasah merged commit 23444ef into zhinst:main Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants