Tobiasa/no capnp request #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds a barrier for exceptions raised within in the core session and the underlying capnp.
This commit adds a custom loop manager that manages the lifetime of the kj eventloop used by capnp. The loop manager exposes a destroy function that when called prevents any further operation to capnp. By default this function is registered to the exit of the asyncio event loop. However if needed the user can create an instace of the loop manager before creating a session and manage the lifeime of the loop manager itself. This is especially usefull when the eventloop is stoped and reentered multiple times.
This commit removes the requests mechanism and replaces it with plain function calls. This prevent the existance from references in the python code to capnp and therefore improves the stability in case of exceptions.
tobiasah
force-pushed
the
tobiasa/no_capnp_request
branch
from
8f59e7a to
07fb3cf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 1911 1937 +26
Branches 294 321 +27
=========================================
+ Hits 1911 1937 +26 ☔ View full report in Codecov by Sentry. |
markheik
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes to improve the stability when exceptions are raised by pycapnp within RPC calls.