From f34d14280db442e26ff97d52c2949d0872ffe105 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E6=B2=88=E5=94=81?= <52o@qq52o.cn>
Date: Tue, 15 Feb 2022 11:10:47 +0800
Subject: [PATCH] Fix compatibility with PHP 8.1 (#1324)

* Fix compatibility with PHP 8.1

PHP Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in typecho/var/Widget/Archive.php on line 1292

* Fix login

* Fix write

* Fix manage

* Fix PHP Deprecated
---
 admin/login.php           | 4 ++--
 admin/manage-comments.php | 2 +-
 admin/manage-medias.php   | 2 +-
 admin/manage-pages.php    | 2 +-
 admin/manage-users.php    | 2 +-
 admin/write-page.php      | 4 ++--
 admin/write-post.php      | 8 ++++----
 var/Typecho/Response.php  | 2 +-
 var/Widget/Archive.php    | 2 +-
 var/Widget/User.php       | 2 +-
 10 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/admin/login.php b/admin/login.php
index 3c49bd3629..e51d5789d2 100644
--- a/admin/login.php
+++ b/admin/login.php
@@ -4,7 +4,7 @@
 if ($user->hasLogin()) {
     $response->redirect($options->adminUrl);
 }
-$rememberName = htmlspecialchars(\Typecho\Cookie::get('__typecho_remember_name'));
+$rememberName = htmlspecialchars(\Typecho\Cookie::get('__typecho_remember_name', ''));
 \Typecho\Cookie::delete('__typecho_remember_name');
 
 $bodyClass = 'body-100';
@@ -25,7 +25,7 @@
             </p>
             <p class="submit">
                 <button type="submit" class="btn btn-l w-100 primary"><?php _e('登录'); ?></button>
-                <input type="hidden" name="referer" value="<?php echo htmlspecialchars($request->get('referer')); ?>" />
+                <input type="hidden" name="referer" value="<?php echo htmlspecialchars($request->get('referer') ?? ''); ?>" />
             </p>
             <p>
                 <label for="remember">
diff --git a/admin/manage-comments.php b/admin/manage-comments.php
index b97d20e3a1..b8ede5f383 100644
--- a/admin/manage-comments.php
+++ b/admin/manage-comments.php
@@ -69,7 +69,7 @@
                             (isset($request->status) ? 'status=' . htmlspecialchars($request->get('status')) : '') .
                             (isset($request->cid) ? (isset($request->status) ? '&' : '') . 'cid=' . htmlspecialchars($request->get('cid')) : '') : '')); ?>"><?php _e('&laquo; 取消筛选'); ?></a>
                             <?php endif; ?>
-                            <input type="text" class="text-s" placeholder="<?php _e('请输入关键字'); ?>" value="<?php echo htmlspecialchars($request->keywords); ?>"<?php if ('' == $request->keywords): ?> onclick="value='';name='keywords';" <?php else: ?> name="keywords"<?php endif; ?>/>
+                            <input type="text" class="text-s" placeholder="<?php _e('请输入关键字'); ?>" value="<?php echo htmlspecialchars($request->keywords ?? ''); ?>"<?php if ('' == $request->keywords): ?> onclick="value='';name='keywords';" <?php else: ?> name="keywords"<?php endif; ?>/>
                             <?php if(isset($request->status)): ?>
                                 <input type="hidden" value="<?php echo htmlspecialchars($request->get('status')); ?>" name="status" />
                             <?php endif; ?>
diff --git a/admin/manage-medias.php b/admin/manage-medias.php
index 7f41136c43..3814f1bffe 100644
--- a/admin/manage-medias.php
+++ b/admin/manage-medias.php
@@ -36,7 +36,7 @@ class="i-caret-down"></i></button>
                                 <a href="<?php $options->adminUrl('manage-medias.php'); ?>"><?php _e('&laquo; 取消筛选'); ?></a>
                             <?php endif; ?>
                             <input type="text" class="text-s" placeholder="<?php _e('请输入关键字'); ?>"
-                                   value="<?php echo htmlspecialchars($request->keywords); ?>"<?php if ('' == $request->keywords): ?> onclick="value='';name='keywords';" <?php else: ?> name="keywords"<?php endif; ?>/>
+                                   value="<?php echo htmlspecialchars($request->keywords ?? ''); ?>"<?php if ('' == $request->keywords): ?> onclick="value='';name='keywords';" <?php else: ?> name="keywords"<?php endif; ?>/>
                             <button type="submit" class="btn btn-s"><?php _e('筛选'); ?></button>
                         </div>
                     </form>
diff --git a/admin/manage-pages.php b/admin/manage-pages.php
index 897a7e7d4d..d51507659d 100644
--- a/admin/manage-pages.php
+++ b/admin/manage-pages.php
@@ -39,7 +39,7 @@ class="i-caret-down"></i></button>
                                 <a href="<?php $options->adminUrl('manage-pages.php'); ?>"><?php _e('&laquo; 取消筛选'); ?></a>
                             <?php endif; ?>
                             <input type="text" class="text-s" placeholder="<?php _e('请输入关键字'); ?>"
-                                   value="<?php echo htmlspecialchars($request->keywords); ?>" name="keywords"/>
+                                   value="<?php echo htmlspecialchars($request->keywords ?? ''); ?>" name="keywords"/>
                             <button type="submit" class="btn btn-s"><?php _e('筛选'); ?></button>
                         </div>
                     </form>
diff --git a/admin/manage-users.php b/admin/manage-users.php
index 025efe24ae..c4b8186b58 100644
--- a/admin/manage-users.php
+++ b/admin/manage-users.php
@@ -31,7 +31,7 @@ class="i-caret-down"></i></button>
                                 <a href="<?php $options->adminUrl('manage-users.php'); ?>"><?php _e('&laquo; 取消筛选'); ?></a>
                             <?php endif; ?>
                             <input type="text" class="text-s" placeholder="<?php _e('请输入关键字'); ?>"
-                                   value="<?php echo htmlspecialchars($request->keywords); ?>" name="keywords"/>
+                                   value="<?php echo htmlspecialchars($request->keywords ?? ''); ?>" name="keywords"/>
                             <button type="submit" class="btn btn-s"><?php _e('筛选'); ?></button>
                         </div>
                     </form>
diff --git a/admin/write-page.php b/admin/write-page.php
index 25c4820a15..4ab81db728 100644
--- a/admin/write-page.php
+++ b/admin/write-page.php
@@ -34,7 +34,7 @@ class="edit-draft-notice"><?php _e('当前正在编辑的是保存于%s的草稿
                     if ($page->have()) {
                         $permalink = str_replace('{cid}', $page->cid, $permalink);
                     }
-                    $input = '<input type="text" id="slug" name="slug" autocomplete="off" value="' . htmlspecialchars($page->slug) . '" class="mono" />';
+                    $input = '<input type="text" id="slug" name="slug" autocomplete="off" value="' . htmlspecialchars($page->slug ?? '') . '" class="mono" />';
                     ?>
                     <p class="mono url-slug">
                         <label for="slug" class="sr-only"><?php _e('网址缩略名'); ?></label>
@@ -43,7 +43,7 @@ class="edit-draft-notice"><?php _e('当前正在编辑的是保存于%s的草稿
                     <p>
                         <label for="text" class="sr-only"><?php _e('页面内容'); ?></label>
                         <textarea style="height: <?php $options->editorSize(); ?>px" autocomplete="off" id="text"
-                                  name="text" class="w-100 mono"><?php echo htmlspecialchars($page->text); ?></textarea>
+                                  name="text" class="w-100 mono"><?php echo htmlspecialchars($page->text ?? ''); ?></textarea>
                     </p>
 
                     <?php include 'custom-fields.php'; ?>
diff --git a/admin/write-post.php b/admin/write-post.php
index 896b4b0057..1f9a40a877 100644
--- a/admin/write-post.php
+++ b/admin/write-post.php
@@ -38,7 +38,7 @@ class="edit-draft-notice"><?php _e('你正在编辑的是保存于 %s 的草稿,
                             $post->cid, $post->category, $post->year, $post->month, $post->day
                         ], $permalink);
                     }
-                    $input = '<input type="text" id="slug" name="slug" autocomplete="off" value="' . htmlspecialchars($post->slug) . '" class="mono" />';
+                    $input = '<input type="text" id="slug" name="slug" autocomplete="off" value="' . htmlspecialchars($post->slug ?? '') . '" class="mono" />';
                     ?>
                     <p class="mono url-slug">
                         <label for="slug" class="sr-only"><?php _e('网址缩略名'); ?></label>
@@ -47,7 +47,7 @@ class="edit-draft-notice"><?php _e('你正在编辑的是保存于 %s 的草稿,
                     <p>
                         <label for="text" class="sr-only"><?php _e('文章内容'); ?></label>
                         <textarea style="height: <?php $options->editorSize(); ?>px" autocomplete="off" id="text"
-                                  name="text" class="w-100 mono"><?php echo htmlspecialchars($post->text); ?></textarea>
+                                  name="text" class="w-100 mono"><?php echo htmlspecialchars($post->text ?? ''); ?></textarea>
                     </p>
 
                     <?php include 'custom-fields.php'; ?>
@@ -134,7 +134,7 @@ class="i-caret-down"></i></button>
                                                 <option
                                                     value="hidden"<?php if ($post->status == 'hidden'): ?> selected<?php endif; ?>><?php _e('隐藏'); ?></option>
                                                 <option
-                                                    value="password"<?php if (strlen($post->password) > 0): ?> selected<?php endif; ?>><?php _e('密码保护'); ?></option>
+                                                    value="password"<?php if (strlen($post->password ?? '') > 0): ?> selected<?php endif; ?>><?php _e('密码保护'); ?></option>
                                                 <option
                                                     value="private"<?php if ($post->status == 'private'): ?> selected<?php endif; ?>><?php _e('私密'); ?></option>
                                             <?php endif; ?>
@@ -142,7 +142,7 @@ class="i-caret-down"></i></button>
                                                 value="waiting"<?php if (!$user->pass('editor', true) || $post->status == 'waiting'): ?> selected<?php endif; ?>><?php _e('待审核'); ?></option>
                                         </select>
                                     </p>
-                                    <p id="post-password"<?php if (strlen($post->password) == 0): ?> class="hidden"<?php endif; ?>>
+                                    <p id="post-password"<?php if (strlen($post->password ?? '') == 0): ?> class="hidden"<?php endif; ?>>
                                         <label for="protect-pwd" class="sr-only">内容密码</label>
                                         <input type="text" name="password" id="protect-pwd" class="text-s"
                                                value="<?php $post->password(); ?>" size="16"
diff --git a/var/Typecho/Response.php b/var/Typecho/Response.php
index 57f19fae29..fa11d56547 100644
--- a/var/Typecho/Response.php
+++ b/var/Typecho/Response.php
@@ -209,7 +209,7 @@ public function sendHeaders()
                 $timeout = 1;
             }
 
-            setrawcookie($key, rawurlencode($value), $timeout, $path, $domain);
+            setrawcookie($key, rawurlencode($value), $timeout, $path, $domain ?? '');
         }
     }
 
diff --git a/var/Widget/Archive.php b/var/Widget/Archive.php
index 621f83ba29..1bd3b5ea62 100644
--- a/var/Widget/Archive.php
+++ b/var/Widget/Archive.php
@@ -1289,7 +1289,7 @@ public function remember(string $cookieName, bool $return = false)
         if ($return) {
             return $value;
         } else {
-            echo htmlspecialchars($value);
+            echo htmlspecialchars($value ?? '');
         }
     }
 
diff --git a/var/Widget/User.php b/var/Widget/User.php
index 94dc92318a..700bf1ad2a 100644
--- a/var/Widget/User.php
+++ b/var/Widget/User.php
@@ -268,7 +268,7 @@ public function pass(string $group, bool $return = false): bool
             } else {
                 //防止循环重定向
                 $this->response->redirect(defined('__TYPECHO_ADMIN__') ? $this->options->loginUrl .
-                    (0 === strpos($this->request->getReferer(), $this->options->loginUrl) ? '' :
+                    (0 === strpos($this->request->getReferer() ?? '', $this->options->loginUrl) ? '' :
                         '?referer=' . urlencode($this->request->makeUriByRequest())) : $this->options->siteUrl, false);
             }
         }