Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic editor fails to load in Visual #12

Closed
bobbingwide opened this issue Jan 25, 2018 · 3 comments
Closed

Classic editor fails to load in Visual #12

bobbingwide opened this issue Jan 25, 2018 · 3 comments

Comments

@bobbingwide
Copy link

With the current version of Gutenberg ( 2.0.0 ), the action hook enqueue_block_assets is invoked even when using the Classic editor. This invokes jsforwpblocks_scripts() which enqueues the React Javascript which is incompatible with the Classic editor's TinyMCE. This results in TinyMCE failing to load.

I raised this in WordPress/gutenberg#4672 (comment)
Now I understand it better I'm considering whether or not to raise a separate issue on Gutenberg.

@bobbingwide
Copy link
Author

I did raise a separate issue. It is WordPress/gutenberg#4678 and I'm working on a PR to fix it WordPress/gutenberg#4693

@zgordon
Copy link
Owner

zgordon commented Apr 9, 2018

Hey @bobbingwide interesting notes. Do you know if this was resolved?

@bobbingwide
Copy link
Author

No, I don't think it has been fixed yet. Perhaps we can talk about this at #wcldn Contributor day.

Items to address...

  1. To determine if I'm the only person who has this problem.
  2. To check if my proposed solution actually makes sense.
    See Enqueue editor and block scripts only when necessary bobbingwide/oik-block#8
  3. If not, to determine what is necessary.
  4. To take see if the changes to the PHP register_block_type()'s $args parameter
    makes it easier to safely register scripts and styles, without having to hook into the actions.
  5. And if so, to determine the best way to change the code and build processes to support this mechanism.

@zgordon zgordon closed this as completed Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants