Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

PatchKey uses ReplaceKey #21

Open
TomHAnderson opened this issue May 17, 2017 · 4 comments
Open

PatchKey uses ReplaceKey #21

TomHAnderson opened this issue May 17, 2017 · 4 comments

Comments

@TomHAnderson
Copy link

The function patchKey does not actually patch a key. It uses replaceKey to do the heavy lifting:
https://github.com/zfcampus/zf-configuration/blob/master/src/ConfigResource.php#L118

I submit patchKey should read the current key and merge the arrays.

@TomHAnderson
Copy link
Author

This is still a big issue for zf-apigility-doctrine users because the query_create_filters and query_providers are all lost. These are a major source of security information for an app.

This issue was closed for 1.3.1 which was reverted to 1.3.2 and remains unfixed today. Will you please re-open this issue and prioritize it high.

@weierophinney
Copy link
Member

@TomHAnderson Please review #378. The reason it was reverted is because it breaks the admin. The original author of #25 does not feel it can be accomplished without a BC break, and, right now, that's a no-go.

If you can propose a solution that does not break the admin, we will certainly review it.

I'm re-opening, so we don't lose track of it, but it's not something we are going to prioritize at this time, due to the BC implications.

@weierophinney weierophinney reopened this Mar 7, 2018
@TomHAnderson
Copy link
Author

Seeing this fixed is a priority to me so I'll dig through it to see about fixing the library and fixing the admin. I (should) have down time in a couple weeks in SF to investigate.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas-api-tools/api-tools-configuration; a new issue has been opened at laminas-api-tools/api-tools-configuration#2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants