-
Notifications
You must be signed in to change notification settings - Fork 12
PatchKey uses ReplaceKey #21
Comments
Hotfix #21 - patchKey merge configuration instead of override
This is still a big issue for zf-apigility-doctrine users because the query_create_filters and query_providers are all lost. These are a major source of security information for an app. This issue was closed for 1.3.1 which was reverted to 1.3.2 and remains unfixed today. Will you please re-open this issue and prioritize it high. |
@TomHAnderson Please review #378. The reason it was reverted is because it breaks the admin. The original author of #25 does not feel it can be accomplished without a BC break, and, right now, that's a no-go. If you can propose a solution that does not break the admin, we will certainly review it. I'm re-opening, so we don't lose track of it, but it's not something we are going to prioritize at this time, due to the BC implications. |
Seeing this fixed is a priority to me so I'll dig through it to see about fixing the library and fixing the admin. I (should) have down time in a couple weeks in SF to investigate. |
This repository has been closed and moved to laminas-api-tools/api-tools-configuration; a new issue has been opened at laminas-api-tools/api-tools-configuration#2. |
The function
patchKey
does not actually patch a key. It usesreplaceKey
to do the heavy lifting:https://github.com/zfcampus/zf-configuration/blob/master/src/ConfigResource.php#L118
I submit patchKey should read the current key and merge the arrays.
The text was updated successfully, but these errors were encountered: