initial commit of nambu code #877
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added matrix codes to create the Nambu Hamiltonian. This required restructuring the diag fold_csr matrix codes. Now they can be given a number to determine the number of elements that are added. It generalizes the code a bit. Currently the matrix creation does not implement the no-phase code-path. So Gamma-point is not functional. Changed some of the cython codes to use preprocessors at the comment level at the top of the file. It makes it much simpler to debug. Enabled siesta routines to read the matrices with Nambu spin configuration. Signed-off-by: Nick Papior <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -59,30 +66,42 @@ | |||
| assert s2 > s1 | |||
| assert s3 > s2 | |||
| assert s4 > s3 | |||
| assert s5 > s4 | |||
Check warning
Code scanning / CodeQL
Redundant comparison Warning test
|
|
||
| assert s2 >= s1 | ||
| assert s3 >= s2 | ||
| assert s4 >= s3 | ||
| assert s5 >= s4 |
Check warning
Code scanning / CodeQL
Redundant comparison Warning test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
- Coverage 86.95% 86.82% -0.14%
==========================================
Files 405 405
Lines 52714 52967 +253
==========================================
+ Hits 45838 45986 +148
- Misses 6876 6981 +105 ☔ View full report in Codecov by Sentry. |
- nambu PDOS - nambu transpose - nambu berry-phase stuff works - nambu trs is *NOT* implemented. Added more tests for complex data-types which has been completed in this branch. Signed-off-by: Nick Papior <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added matrix codes to create the Nambu
Hamiltonian.
This required restructuring the diag
fold_csr matrix codes. Now they can be given
a number to determine the number of elements
that are added. It generalizes the code a bit.
Currently the matrix creation does not implement
the no-phase code-path. So Gamma-point is not functional.
Changed some of the cython codes to use preprocessors at the comment level at the top of the file.
It makes it much simpler to debug.
Enabled siesta routines to read the matrices
with Nambu spin configuration.
docs/CHANGELOG.md