@tank-bohr Maybe need add test for issue-was-closed case

@tank-bohr I agree with @Yegorov. We need a test for issue-was-closed case

@tank-bohr The self.issue_event_exists? method checks whether an issue exists or not, but based on the name of the method, it seems that the method is checking for the existence of an event in an issue. What about the name self.issue_exists??
@Yegorov What do you think?

@Suban05 I find it difficult to comment, but the event is called IssuesEvent, but on the other hand, an issue is being processed here.
@yegor256 what do you think?

@Yegorov I would call it self.issue_seen_already?(fact, what), since we are checking the presence of a fact with the given what

@yegor256 issue_seen_already? - readable name.

@Suban05 @yegor256 What do you think if call issue_seen_already? method after get what fact, we may not use the last argument in this method. For example:

     def self.issue_seen_already?(fact)
        Fbe.fb.query(
          "(and (eq repository #{fact.repository}) " \
          "(eq what #{fact.what}) " \
          "(eq issue #{fact.issue}))"
        ).each.any?
      end

      # ...
      case json[:payload][:action]
      when 'closed'
        fact.what = 'issue-was-closed'
        skip_event(json) if issue_seen_already?(fact)
        fact.details = "The issue #{Fbe.issue(fact)} has been closed by #{Fbe.who(fact)}."
      when 'opened'
        fact.what = 'issue-was-opened'
        skip_event(json) if issue_seen_already?(fact)
        fact.details = "The issue #{Fbe.issue(fact)} has been opened by #{Fbe.who(fact)}."

@Yegorov excellent idea! Maybe, we can do this checking at the end of the entire processing of all events? We don't want to have duplicates with any of them.

@yegor256 Good point, as an option I think yes

@Yegorov yes, perfect, it looks much better

If we set what before checking the factbase, will the issue_seen_already? find this fact exactly?

@tank-bohr good point. You can do this:

count = Fbe.fb.query("
  (agg 
    (and 
      (eq repository #{fact.repository}) 
      (eq what #{fact.what}) 
      (eq issue #{fact.issue}))
    (count))
).each.to_a.first

You should get a count of facts that satisfy the (and ...) term. If the count is larger than 1, you can do skip_event.

You can also do a simple Ruby counting:

count = Fbe.fb.query("
    (and 
      (eq repository #{fact.repository}) 
      (eq what #{fact.what}) 
      (eq issue #{fact.issue}))
).each.to_a.count

@tank-bohr don't forget about where, it should be set to github. We may have GitLab, for example, in the same factbase.

@yegor256 But can we handle the events of gitlab in a file that called github - judges/github-events/github-events.rb ?

@Yegorov In the github-events file, we process events only from github, I think it is proposed to put a filter only on events from github like eq where 'github', so as not to accidentally receive events from gitlab, for example

@Suban05 @yegor256 ok, understood (the search was taking place in the general storage Fbe.fb).
Then maybe there is the same check should be done here - #278