#156: implement calculate rejection pull request rate for repos #205
Conversation
|
@Yegorov good to continue here? |
|
@yegor256 I pushed updated PR |
| all_q = "repo:#{repo} type:pr closed:>#{$SINCE.utc.iso8601[0..10]}" | ||
| all_prs_count += Fbe.octo.search_issues(all_q)[:total_count] | ||
|
|
||
| unmerged_q = "repo:#{repo} type:pr is:unmerged closed:>#{$SINCE.utc.iso8601[0..10]}" |
There was a problem hiding this comment.
@Yegorov same here, this variable is a noise: https://www.yegor256.com/2015/09/01/redundant-variables-are-evil.html
There was a problem hiding this comment.
@yegor256 Does it really look better?
unmerged_prs_count += Fbe.octo.search_issues("repo:#{repo} type:pr is:unmerged closed:>#{$SINCE.utc.iso8601[0..10]}")[:total_count]what is it
unmerged_q = "repo:#{repo} type:pr is:unmerged closed:>#{$SINCE.utc.iso8601[0..10]}"
unmerged_prs_count += Fbe.octo.search_issues(unmerged_q)[:total_count]And in the end I get this
judges/quality-of-service/quality-of-service.rb:114:121: C: Layout/LineLength: Line is too long. [133/120]
unmerged_prs_count += Fbe.octo.search_issues("repo:#{repo} type:pr is:unmerged closed:>#{$SINCE.utc.iso8601[0..10]}")[:total_count]
unmerged_prs_count += Fbe.octo.search_issues(
"repo:#{repo} type:pr is:unmerged closed:>#{$SINCE.utc.iso8601[0..10]}"
)[:total_count]
|
@yegor256 fixed |
| "repo:#{repo} type:pr is:unmerged closed:>#{$SINCE.utc.iso8601[0..10]}" | ||
| )[:total_count] | ||
| end | ||
| f.average_pull_rejection_rate = |
There was a problem hiding this comment.
@Yegorov if you make variable names shorter, you can write this expression in just one line
There was a problem hiding this comment.
@yegor256 no, 3 symbols left
judges/quality-of-service/quality-of-service.rb:114:121: C: Layout/LineLength: Line is too long. [123/120]
rejected += Fbe.octo.search_issues("repo:#{repo} type:pr is:unmerged closed:>#{$SINCE.utc.iso8601[0..10]}")[:total_count]
^^^
There was a problem hiding this comment.
@Yegorov you don't need to check for rejected.zero?, just a check for pulls.zero? is enough
|
@yegor256 fixed |
|
@Yegorov thanks! |
|
@yegor256 Hey there! 👋 Great job on the review! You've snagged +37 points: +25 for being an awesome reviewer, and +12 for those 12 thoughtful comments you made. That's some solid work! 🌟 Just a heads up, we award points for hits-of-code too, so keep that in mind for future reviews. Your current balance is sitting at -581. Keep up the fantastic work, and let's see that balance climb! 💪 |
Merge this PR fbe#48 before