Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the unresolved comments count, but it should not be #308

Closed
Suban05 opened this issue Aug 22, 2024 · 2 comments · Fixed by zerocracy/fbe#80
Closed

the unresolved comments count, but it should not be #308

Suban05 opened this issue Aug 22, 2024 · 2 comments · Fixed by zerocracy/fbe#80
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Suban05
Copy link
Contributor

Suban05 commented Aug 22, 2024

@yegor256 in this pr #296 we have an unresolved conversation:

{
    "data": {
        "repository": {
            "pullRequest": {
                "reviewThreads": {
                    "nodes": [
                        {
                            "id": "PRRT_kwDOL6J6Ss5Bowwb",
                            "isResolved": false,
                            "comments": {
                                "nodes": [
                                    {
                                        "id": "PRRC_kwDOL6J6Ss5mrYua",
                                        "body": "@Suban05 Why not use web mock for this cases? Testing mode used for run yml files, for example - https://github.com/zerocracy/judges-action/blob/master/judges/github-events/quick-scan.yml",
                                        "author": {
                                            "login": "Yegorov"
                                        },
                                        "createdAt": "2024-08-20T03:49:18Z"
                                    },
                                    {
                                        "id": "PRRC_kwDOL6J6Ss5mrhrm",
                                        "body": "@Yegorov good question. For the `pull-was-merged` event,  we use `Fbe.github_graph`. Maybe I don't understand something, but it's very difficult to mock this thing by `WebMock`. And I use a fake client for `Fbe.github_graph`. However, there is an `options` argument  in both clients (`Fbe.octo` and `Fbe.github_graph`), and when I set `testing` globally, `Fbe.octo` also becomes a fake client. That's why I use fake clients",
                                        "author": {
                                            "login": "Suban05"
                                        },
                                        "createdAt": "2024-08-20T04:56:54Z"
                                    }
                                ]
                            }
                        }
                    ]
                }
            }
        }
    }
}

but it has been written as a resolved:

image

It looks like a bug...

@yegor256
Copy link
Member

@Suban05 I agree, thanks for reporting

@yegor256 yegor256 added bug Something isn't working help wanted Extra attention is needed labels Aug 22, 2024
@0crat
Copy link

0crat commented Aug 22, 2024

@Suban05 Congratulations on reporting a new bug! As per our work policy, you've earned 16 points for your valuable contribution. Your keen eye helps enhance our project's quality. Remember, if you spot anything else in the repository that doesn't look up to par, don't hesitate to report it. Keep up the great work! Your current balance stands at +531 points. 🐛✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants