From fbcc124668d704b954fef3aaed6f4e7d1174f40c Mon Sep 17 00:00:00 2001 From: Suban05 Date: Wed, 21 Aug 2024 23:36:48 +0500 Subject: [PATCH 1/2] use correct attributes of the pull request hash --- judges/github-events/github-events.rb | 2 +- test/judges/test-github-events.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/judges/github-events/github-events.rb b/judges/github-events/github-events.rb index 035e4b6b..ee1b1d60 100644 --- a/judges/github-events/github-events.rb +++ b/judges/github-events/github-events.rb @@ -93,7 +93,7 @@ def self.comments_info(pr) issue_comments.count { |comment| comment[:user][:id] != pr[:user][:id] }, comments_appreciated: count_appreciated_comments(pr, issue_comments, code_comments), comments_resolved: Fbe.github_graph.resolved_conversations( - pr[:base][:login], pr[:base][:repo][:name], pr[:number] + pr[:base][:repo][:owner][:login], pr[:base][:repo][:name], pr[:number] ).count } end diff --git a/test/judges/test-github-events.rb b/test/judges/test-github-events.rb index b86417a8..1eef902e 100644 --- a/test/judges/test-github-events.rb +++ b/test/judges/test-github-events.rb @@ -905,7 +905,7 @@ def test_release_event_contributors def test_pull_request_event_with_comments fb = Factbase.new - load_it('github-events', fb, Judges::Options.new({ 'repositories' => 'foo/foo', 'testing' => true })) + load_it('github-events', fb, Judges::Options.new({ 'repositories' => 'zerocracy/baza', 'testing' => true })) f = fb.query('(eq what "pull-was-merged")').each.to_a.first assert_equal(4, f.comments) assert_equal(2, f.comments_to_code) From b915d38eba604c84f44af4a8c92712fbdb9fbb37 Mon Sep 17 00:00:00 2001 From: Suban05 Date: Thu, 22 Aug 2024 11:13:32 +0500 Subject: [PATCH 2/2] fbe up --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 5eda4dea..318f26d4 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -64,7 +64,7 @@ GEM net-http faraday-retry (2.2.1) faraday (~> 2.0) - fbe (0.0.57) + fbe (0.0.58) backtrace (> 0) decoor (> 0) factbase (> 0)