Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

judjes-action#156: add pull requests to Fbe::FakeOctokit#search_issues #48

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

Yegorov
Copy link
Contributor

@Yegorov Yegorov commented Jul 30, 2024

No description provided.

@yegor256
Copy link
Member

@Yegorov in general, it's not good practice to make changes to the code without adding (or modifying) unit tests

@Yegorov
Copy link
Contributor Author

Yegorov commented Jul 31, 2024

@yegor256 ok, I added a test

@yegor256 yegor256 merged commit 0fa4602 into zerocracy:master Jul 31, 2024
8 of 9 checks passed
@yegor256
Copy link
Member

@Yegorov thanks!

@yegor256
Copy link
Member

@Yegorov we need to release a new version?

@Yegorov
Copy link
Contributor Author

Yegorov commented Jul 31, 2024

@Yegorov we need to release a new version?

@yegor256 yes of course

@Yegorov
Copy link
Contributor Author

Yegorov commented Jul 31, 2024

@yegor256 also see this

@yegor256
Copy link
Member

@rultor release, tag is 0.0.35

@rultor
Copy link
Contributor

rultor commented Jul 31, 2024

@rultor release, tag is 0.0.35

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jul 31, 2024

@rultor release, tag is 0.0.35

@yegor256 Done! FYI, the full log is here (took me 8min)

@0crat
Copy link

0crat commented Jul 31, 2024

@Yegorov Thanks for the contribution! You've earned +11 points for this: +30 as a basis; +6 for the 69 hits-of-code that you wrote; -15 for the lack of code review; -10 for too few (2) comments. Please, keep them coming. Your running balance is +40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants