Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voice-recognition Element does not clear it's previous result, on a new run #32

Open
avdaredevil opened this issue Dec 24, 2015 · 4 comments

Comments

@avdaredevil
Copy link

Hi, I am having a pestering problem where the last result get's appended to the current result, the more times I trigger the element, the way I solved this was by keeping a track of how long the last e.detail.result was and accordingly substring out that length from the next result, but this is a sure shot way of creating memory leaks, or unnecessary computation.

Is it possible to clear the internal results after a on-result is triggered. Thanks.

@che-effe
Copy link

Yes please I would love a better way to handle this issue.

@che-effe
Copy link

I just submitted a PR to fix this, #35

@che-effe
Copy link

@zenorocha Will #35 this cause any issues with how you intend this to function?

@masonlouchart
Copy link
Collaborator

masonlouchart commented Dec 5, 2017

The PR was merged, I tested the branch master and it works, so I guess this issue can be closed 🤓.

The repo isn't really active so, it is possible to make a release patch to get the fix without using master @zenorocha ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants