-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 19 will remove findDOMNode #972
Comments
Just in case. In the Quill playground, there's an example of using Quill with React: https://quilljs.com/playground/react |
Here's a PR that proposes a fix for this issue: #980. Not sure if the maintainer(s) are actively monitoring, but I have been testing it locally and it works great. |
@zenoamaro @alexkrolick It looks like we have a pull request open that resolves this issue (#980). Could you review and approve? |
You can use this meanwhile, added your fix here: |
This repository is not being maintained, so I'm trying to maintain a fork in the interim. See react-quill-new. The fork updates the underlying Quill dependency that uses the deprecated event to use the newer API instead, and also updates type definitions and build process. Follow #973 for updates on that. |
@VaguelySerious thanks a lot, in the package you have provided you also fixed other issues, like returning to new line, class styles etc.. |
React 19 will be officially released in June/July 2024 and it removes the deprecated
ReactDOM.findDOMNode
utility. It appears that this will preventreact-quill
users from upgrading to React 19.I recently installed React 18.3 (which was released about a week ago) and it started issuing warnings about this:
I didn't see another issue opened regarding the removal of
findDOMNode
so I thought I'd bring this issue to the attention of the maintainers (@zenoamaro @alexkrolick).Thank you for your on-going maintenance of this project!
Ticket due diligence
v2.0.0-beta.2
ReactQuill version
The text was updated successfully, but these errors were encountered: