AWS Image Builder implementation #2904

stefannica · 2024-08-05T12:28:51Z

Describe changes

This PR implements a new stack component: an AWS Image Builder that uses AWS CloudBuild to build container images remotely.

Side Changes

AWS CloudBuild requires the docker context files to be archived as a zip file. This PR extends the Archiver base class to add zip support on top of the existing tar and tar+gzip formats.

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

coderabbitai · 2024-08-05T12:28:55Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

schustmi

Have a few minor comments on the code, but looks great overall!
Docs are still missing though 😉

src/zenml/utils/archivable.py

src/zenml/integrations/aws/flavors/aws_image_builder_flavor.py

src/zenml/integrations/aws/image_builders/aws_image_builder.py

github-actions · 2024-12-02T13:47:28Z

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

github-actions · 2024-12-02T13:48:02Z

Classification template updates in examples/mlops_starter have been pushed.

github-actions · 2024-12-02T13:54:53Z

E2E template updates in examples/e2e have been pushed.

github-actions · 2024-12-02T13:57:39Z

NLP template updates in examples/e2e_nlp have been pushed.

hyperlint-ai

2 files reviewed, 1 total issue(s) found.

docs/book/component-guide/image-builders/aws.md

bcdurak

Briefly went over the docs as well. Only a few minor changes needed.

docs/book/component-guide/image-builders/aws.md

src/zenml/integrations/aws/flavors/aws_image_builder_flavor.py

bcdurak · 2024-12-02T14:15:28Z

This space is synced to your branch if you would like to check it out as well.

… into feature/aws-image-builder

hyperlint-ai

3 files reviewed, 2 total issue(s) found.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

[Ee]ndcode
[Bb]oolean
[Ee]ndtab
[Ee]ndhint
[Ee]ndtabs

docs/book/component-guide/image-builders/aws.md

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

Co-authored-by: Barış Can Durak <[email protected]>

github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Aug 5, 2024

stefannica force-pushed the feature/aws-image-builder branch 2 times, most recently from d17d470 to 5a77dbe Compare August 29, 2024 17:02

stefannica requested review from schustmi and bcdurak August 29, 2024 18:14

stefannica force-pushed the feature/aws-image-builder branch from 5a77dbe to 463e94d Compare August 29, 2024 18:16

stefannica marked this pull request as ready for review August 29, 2024 18:17

schustmi requested changes Aug 30, 2024

View reviewed changes

stefannica added 3 commits December 2, 2024 12:22

AWS Image Builder implementation

4e947aa

Update docs

75c0953

Applied code review suggestions

cbe5a80

stefannica force-pushed the feature/aws-image-builder branch from 463e94d to cbe5a80 Compare December 2, 2024 11:36

stefannica requested a review from schustmi December 2, 2024 12:53

schustmi approved these changes Dec 2, 2024

View reviewed changes

stefannica and others added 2 commits December 2, 2024 14:45

Add docs

3245962

Auto-update of LLM Finetuning template

4b85631

Auto-update of Starter template

c0edfb9

Auto-update of E2E template

eb76912

Auto-update of NLP template

04bc9f3

hyperlint-ai bot reviewed Dec 2, 2024

View reviewed changes

docs/book/component-guide/image-builders/aws.md Outdated Show resolved Hide resolved

bcdurak requested changes Dec 2, 2024

View reviewed changes

stefannica added 2 commits December 2, 2024 18:15

Update docs, image builder flavor arguments and fix archiver bug

175d34b

Merge branch 'feature/aws-image-builder' of github.com:zenml-io/zenml…

6f313cf

… into feature/aws-image-builder

hyperlint-ai bot reviewed Dec 2, 2024

View reviewed changes

docs/book/component-guide/image-builders/aws.md Outdated Show resolved Hide resolved

docs/book/component-guide/image-builders/aws.md Outdated Show resolved Hide resolved

stefannica and others added 5 commits December 2, 2024 18:17

Update docs/book/component-guide/image-builders/aws.md

e5867e8

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

Update docs/book/component-guide/image-builders/aws.md

5d1f8bd

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

Update docs/book/component-guide/image-builders/aws.md

2eaf117

Co-authored-by: Barış Can Durak <[email protected]>

Add aws image builder page to TOC

7fad641

Add the CloudBuild image builder to the AWS one-click stack deployment

d41fdb0

stefannica added the run-slow-ci label Dec 2, 2024

stefannica requested a review from bcdurak December 2, 2024 20:42

stefannica added 2 commits December 2, 2024 21:50

Update one-click deployment docs for AWS

12574a3

Remove stack wizard mention from AWS image builder doc

5a52c9f

bcdurak approved these changes Dec 3, 2024

View reviewed changes

stefannica merged commit aeaae30 into develop Dec 3, 2024
64 of 67 checks passed

stefannica deleted the feature/aws-image-builder branch December 3, 2024 08:41

stefannica restored the feature/aws-image-builder branch December 3, 2024 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AWS Image Builder implementation #2904

AWS Image Builder implementation #2904

stefannica commented Aug 5, 2024 •

edited

Loading

coderabbitai bot commented Aug 5, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

schustmi left a comment

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

hyperlint-ai bot left a comment

bcdurak left a comment

bcdurak commented Dec 2, 2024

hyperlint-ai bot left a comment

AWS Image Builder implementation #2904

AWS Image Builder implementation #2904

Conversation

stefannica commented Aug 5, 2024 • edited Loading

Describe changes

Side Changes

Pre-requisites

Types of changes

coderabbitai bot commented Aug 5, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

schustmi left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

hyperlint-ai bot left a comment

Choose a reason for hiding this comment

bcdurak left a comment

Choose a reason for hiding this comment

bcdurak commented Dec 2, 2024

hyperlint-ai bot left a comment

Choose a reason for hiding this comment

stefannica commented Aug 5, 2024 •

edited

Loading

coderabbitai bot commented Aug 5, 2024 •

edited

Loading