Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move github-insights in this repository #24

Open
frinyvonnick opened this issue Apr 11, 2019 · 4 comments
Open

Move github-insights in this repository #24

frinyvonnick opened this issue Apr 11, 2019 · 4 comments
Labels
question Further information is requested

Comments

@frinyvonnick
Copy link
Contributor

What do you think of moving github-insights repository here ?
@frinyvonnick frinyvonnick added the question Further information is requested label Apr 11, 2019
@christopherkade
Copy link
Collaborator

Given my most recent PR (Zenika/github-insights#5) it would make sense to have it here to access the generated data directly.

But deploying it as an NPM package and allowing the user to select the folder in which the data will be generated has its merits. I think Github Insights has other use-cases and could help out other people.

@frinyvonnick
Copy link
Contributor Author

Sure but this repository could be a monorepo so we could publish this github-insights as an npm package. What do you think ?

@christopherkade
Copy link
Collaborator

Sounds good to me, where would we move it? At the root under a scripts folder?

@frinyvonnick
Copy link
Contributor Author

I was thinking more about lerna's approach. It's used by a lot of projects. So we could have to packages github-insights and insights-website 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frinyvonnick @christopherkade