Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define active_support dependencies in production. #318

Open
tigris opened this issue Feb 22, 2023 · 0 comments
Open

Define active_support dependencies in production. #318

tigris opened this issue Feb 22, 2023 · 0 comments

Comments

@tigris
Copy link

tigris commented Feb 22, 2023

When using the datadog integration, it seems active_support is required. This can be seen here.

I see there is a helpful error message above if you don't include dogstatsd-ruby, so perhaps the fix here is to simply add the same check for active_support/subscriber? I only mention this becaus I had some trouble just now tracking down what it was in my chain that needed active support.

Lastly, I can see that a dev dependency for this is set to < 6.1. Would this be the same in prod for the above-mentioned code? As I'm not a consumer of active_support personally I can't easily tell. I do however note that another gem (database_cleaner to be exact) wants to make use of activesupport >= 7, so these requirements might get out of hand if that's true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant