Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InbandEventStream should be an element, slice #82

Open
bdstark opened this issue Jul 14, 2020 · 0 comments
Open

InbandEventStream should be an element, slice #82

bdstark opened this issue Jul 14, 2020 · 0 comments

Comments

@bdstark
Copy link

bdstark commented Jul 14, 2020 •
edited
Loading

CommonAttributesAndElements.InbandEventStream has an XML tag to be an attribute, but should be an element:

InbandEventStream         *DescriptorType       `xml:"inbandEventStream,attr"`

should be

InbandEventStream         *DescriptorType       `xml:"InbandEventStream,omitempty"`

otherwise it will never be unmarshaled.

I think is is valid to have multiple InbandEventStream elements, which would need more than just this fix.

InbandEventStream         []DescriptorType      `xml:"InbandEventStream,omitempty"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bdstark