d_a_obj_waterfall OK, with basic documentation #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Found examples of actor in-game * Differentiated between d_a_obj_waterfall & d_a_tag_waterfall
TakaRikka
approved these changes
Nov 11, 2024
Comment on lines
+30
to
+35
| /* 0x574 */ dCcD_Stts mCylColliderStts; | ||
| /* 0x5B0 */ dCcD_Tri mUnusedTriCollider[2]; | ||
| /* 0x868 */ dCcD_Cyl mCylCollider; | ||
| /* 0x9A4 */ cXyz mCylColliderCenterOscillationTargets[2]; | ||
| /* 0x9BC */ cXyz mCylColliderCenter; | ||
| /* 0x9C8 */ s8 mCylColliderCenterQuantizedOscillation; |
There was a problem hiding this comment.
maybe could replace "Collider" in these names with "Cc" or something to help simplify the names? Cc being the name for the shape collider system. just a thought, i dont have particularly strong opinions either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some info to differentiate d_a_obj_waterfall from d_a_tag_waterfall, as well as in-game uses of both.