d_save comments #2185
Closed
d_save comments #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakaRikka
reviewed
Jul 23, 2024
| /** | ||
| * @brief Initializes the horse place data | ||
| * | ||
| * @details Sets default values for the horse's name, position, angle, spawn ID, and room number. |
There was a problem hiding this comment.
should probably say stage name instead of name
| /** | ||
| * @brief Sets the horse place data | ||
| * | ||
| * @param i_name The name of the horse place |
There was a problem hiding this comment.
same thing about stage_name
| @@ -692,7 +982,13 @@ u8 dSv_player_item_c::checkBombBag(u8 i_itemNo) { | |||
| return bombBags; | |||
| } | |||
|
|
|||
| /* 80033C2C-80033CBC 02E56C 0090+00 0/0 2/2 1/1 .text setWarashibeItem__17dSv_player_item_cFUc */ | |||
| /** | |||
| * @brief Sets a Warashibe item | |||
There was a problem hiding this comment.
this could probably have a translation in parenthesis to make it more clear what it is (Trade Item)
Comment on lines
+1004
to
+1006
| * @brief Upgrades the rod type to the next level | ||
| * | ||
| * @details Checks the current rod type and upgrades it to its jewel version |
There was a problem hiding this comment.
may be good to be specific and say Fishing Rod instead of just rod so there's no ambiguity
Comment on lines
+1072
to
+1074
| * @brief Sets the first bit for a given item number | ||
| * | ||
| * @param i_itemNo The item number to set the first bit for |
There was a problem hiding this comment.
these first bit ones may need a bit more description to make it clear that first bit is a flag for saying you've gotten the specified item at least once before. iirc this is important for like rupee flags and such
|
Closing for now, will come back to this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at what a fully commented TU might look like. Also incomplete work on daAlink_c::transAnimeProc