Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d_a_tag_yami work #2154

Merged
merged 3 commits into from
May 14, 2024
Merged

d_a_tag_yami work #2154

merged 3 commits into from
May 14, 2024

Conversation

dooplecks
Copy link
Collaborator

Each function body is a 100% match. However, the built REL does not match due to differences in ordering.

Expected:

  0000061c 00011c 0000061c 0000065c  4 daTagYami_Delete__FP11daTagYami_c 	d_a_tag_yami.o 
  00000738 000048 00000738 00000778  4 __dt__10cCcD_GSttsFv 	d_a_tag_yami.o 
  00000780 00001c 00000780 000007c0  4 setCoC__11daTagYami_cF4cXyz 	d_a_tag_yami.o 
  0000079c 00005c 0000079c 000007dc  4 __dt__10dCcD_GSttsFv 	d_a_tag_yami.o 
  000007f8 000048 000007f8 00000838  4 __dt__8cM3dGCylFv 	d_a_tag_yami.o 

Observed (with -sym on):

  0000061c 00011c 0000061c 0000065c  4 daTagYami_Delete__FP11daTagYami_c 	d_a_tag_yami.o 
  00000738 00001c 00000738 00000778  4 setCoC__11daTagYami_cF4cXyz 	d_a_tag_yami.o 
  00000754 00005c 00000754 00000794  4 __dt__10dCcD_GSttsFv 	d_a_tag_yami.o 
  000007b0 000048 000007b0 000007f0  4 __dt__10cCcD_GSttsFv 	d_a_tag_yami.o 
  000007f8 000048 000007f8 00000838  4 __dt__8cM3dGCylFv 	d_a_tag_yami.o 

It's even worse without -sym on, which causes a mismatch in a different REL file that links to this one.

Any ideas on how to make the order match?

@TakaRikka
Copy link
Contributor

setCoC might be an inline that gets weakly generated, thats my only guess

@dooplecks dooplecks marked this pull request as ready for review May 14, 2024 16:27
@Pheenoh Pheenoh merged commit 35484fb into zeldaret:main May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants