Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d_map OK #2074

Merged
merged 2 commits into from
Feb 17, 2024
Merged

d_map OK #2074

merged 2 commits into from
Feb 17, 2024

Conversation

TakaRikka
Copy link
Contributor

dDlst_base_c::draw is supposed to be autogenerated at the of d_map, but was having issues with it. it should fix other issues with inheriting dDlst_base_c though if it can be generated correctly, so need to look into again at some point

@Trueffeloot
Copy link
Contributor

Trueffeloot commented Feb 17, 2024

I'm 100% sure that dDlst_base_c::draw needs to be defined instead of declared in the header. But that changes so much vtable padding that would need to be fixed and the whole build doesn't match this way currently (even the rels). I believe we have to decompile more or even all classes that inherit from dDlst_base_c and decompile some of their functions (specifically ctors and dtors and virtuals which use the vtable) in order to match the vtable padding. So this will probably take a while if I'm right about what I said

@jdflyer
Copy link
Contributor

jdflyer commented Feb 17, 2024

@Trueffeloot dDlst_base_c::draw is generated. I was looking at the movie player REL a while back and the dDlst_base_c::draw function also gets generated there

@Trueffeloot
Copy link
Contributor

@Trueffeloot dDlst_base_c::draw is generated. I was looking at the movie player REL a while back and the dDlst_base_c::draw function also gets generated there

Yeah it's actually generated in multiple rels for some reason... I don't really understand why

@Trueffeloot Trueffeloot merged commit fa3be5d into zeldaret:main Feb 17, 2024
1 check passed
@TakaRikka TakaRikka deleted the map branch June 14, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants