Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchard Support for FROST UniFFI SDK #65

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Orchard Support for FROST UniFFI SDK #65

merged 1 commit into from
Aug 23, 2024

Conversation

pacu
Copy link
Collaborator

@pacu pacu commented Aug 4, 2024

Closes pacu/zcash-dev-rel-engineer#155
Closes #64
This commit Adds Orchard Support to the UniFFI FROST SDK:

  • Uses Orchard Repo Fork to expose unstable-frost feature
  • Orchard viewing key string encoding
  • Exposes key elements needed to construct an FVK when an ak is
    provided
  • Exposes OrchardCommitIvkRandomness to the FFI
  • Fixes orchard key dependencies.
  • Adds swift test
  • Adds pipefail to scripts
  • Orchard Key tests for Go Lang

@pacu pacu marked this pull request as draft August 4, 2024 23:42
@pacu pacu marked this pull request as ready for review August 19, 2024 20:11
Closes #64

This commit adds Orchard Support to the UniFFI FROST SDK:
- Uses Orchard Repo Fork to expose `unstable-frost` feature
- Enables Orchard viewing key string encoding
- Exposes key elements needed to construct an FVK when an `ak` is
provided
- Exposes `OrchardCommitIvkRandomness` to the FFI
- Fixes orchard key dependencies.
- Adds swift test
- Adds pipefail to scripts
- Orchard Key tests for Go Lang
@pacu pacu merged commit 5b15498 into main Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Orchard Key derivation from Technical Details Section of ZF Book FROST Feature for Orchard Crate
1 participant