Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: note plaintext size generalization #2

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Dec 19, 2023

  1. Add generalization to support OrchardZSA and AssetBase (#1)

    * Copy updated src folder from librustzcash/zsa1
    
    * Cherry-pick the latest update of zcash_note_encryption from zcash/librustzcash (it was missed in QED-it/librustzcash)
    
    * Upgrade Rust version
    
    * Upgrade Rust version to 1.65
    
    * Add --features=alloc to command line for build-nodefault jon in ci.yml
    
    * Downgrade Rust version back to 1.61.0
    
    ---------
    
    Co-authored-by: Dmitry Demin <[email protected]>
    dmidem and dmidem authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e14dab6 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    8b6b31d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Update CHANGELOG.md with changes for note plaintext size generalizati…

    …on (#6)
    
    * Update CHANGELOG.md with changes for note plaintext size generalization
    
    * Improve the description in CHANGELOG.md
    
    ---------
    
    Co-authored-by: Dmitry Demin <[email protected]>
    dmidem and dmidem authored May 16, 2024
    Configuration menu
    Copy the full SHA
    1ca015a View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Revert MSRV to 1.56.1 (#5)

    Co-authored-by: Dmitry Demin <[email protected]>
    dmidem and dmidem authored May 20, 2024
    Configuration menu
    Copy the full SHA
    b8bd2a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Resolve Issues from PR #2 in zcash/zcash_note_encryption repository (#10

    )
    
    * Attempt to resolve review issues for zcash/pull/2
    
    * NoteBytes moved to zcash_note_encryption (copy of #8) (#9)
    
    * Add NoteBytes
    
    * Implement concat manually for wasm
    
    * Fix slice bounds in concat
    
    * Fmt
    
    * Split interface and implementation of NoteBytes
    
    * Add new method to NoteBytes
    
    ---------
    
    Co-authored-by: alexeykoren <[email protected]>
    
    * Resolve review issues for zcash/pull/2 (except returning references from ShieldedOutput methods)
    
    * Fix cargo doc issue
    
    * Fix based on feedback from PR #10 review
    
    * Make split_ciphertext_at_tag a method of ShieldedOutput with minor refactoring
    
    ---------
    
    Co-authored-by: Dmitry Demin <[email protected]>
    Co-authored-by: alexeykoren <[email protected]>
    3 people authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    319c782 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Implement new parse_... methods directly in the Domain trait (#12)

    Co-authored-by: Dmitry Demin <[email protected]>
    dmidem and dmidem authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    5838455 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Refactor enc_ciphertext to return reference instead of copy (#13)

    * Refactor enc_ciphertext to return reference instead of copy
    
    These changes were discussed and suggested in PR zcash_note_encryption#2
    
    * Remove extra spaces in rust-toolchain.toml
    
    * Restore the original order of const definition to reduce PR diff
    
    * Fix the comment for split_plaintext_at_memo
    
    * Fix docstring for NOTE_PLAINTEXT_SIZE
    
    * Update CHANGELOG
    
    * Remove unused constants COMPACT_NOTE_SIZE, NOTE_PLAINTEXT_SIZE, ENC_CIPHERTEXT_SIZE, and update CHANGELOG accordingly
    
    * Minor improvement in CHANGELOG.md
    
    ---------
    
    Co-authored-by: Dmitry Demin <[email protected]>
    dmidem and dmidem authored Aug 12, 2024
    Configuration menu
    Copy the full SHA
    663a2e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Restore visibility for AEAD_TAG_SIZE const (#15)

    Co-authored-by: Dmitry Demin <[email protected]>
    dmidem and dmidem authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    76745f0 View commit details
    Browse the repository at this point in the history