Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_backend: Create the framework for an in-memory wallet backend #1414

Open
str4d opened this issue Jun 13, 2024 · 1 comment · May be fixed by #1293
Open

zcash_client_backend: Create the framework for an in-memory wallet backend #1414

str4d opened this issue Jun 13, 2024 · 1 comment · May be fixed by #1293
Assignees
@oxarbitrage
Labels
A-wallet Area: light wallet backend.
Milestone
Zcashd wallet rep...

Comments

@str4d
Copy link
Contributor

str4d commented Jun 13, 2024 •
edited
Loading

We have a MockWalletDb, but that literally just implements the WalletRead etc. traits with dummy data. In order to make the zcash_client_sqlite tests portable to other wallet backends, we should write an in-memory wallet backend that has no persistence, and stores all of the wallet state directly in memory. This is also a good way for the ZF engineers to gain experience with the zcash_client_backend traits.

As a first step, let's put together the framework for this, with todo!()s for all of the trait method implementations.
@str4d str4d mentioned this issue Jun 13, 2024
Open
@str4d str4d added the A-wallet Area: light wallet backend. label Jun 13, 2024
@str4d str4d linked a pull request Jun 13, 2024 that will close this issue
Draft
@str4d str4d added this to the Zcashd wallet replacement milestone Jun 13, 2024
@pacu
Copy link
Contributor

pacu commented Aug 27, 2024 •
edited
Loading

@nuttycom and myself talked to the ChainSafe team during LCWG call 83 and we agreed they were actually focusing on this already and it would be good for them to complete this with ECC overseeing code style, API, etc. This is on ChainSafe's critical path (as stated by them)

@pacu pacu moved this to Ready in Zcashd Deprecation Sep 3, 2024
@pacu pacu moved this from Ready to In progress in Zcashd Deprecation Sep 3, 2024
@pacu pacu moved this to Ready To be Worked in Zcashd built-in wallet replacement Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-wallet Area: light wallet backend.
Projects
None yet
Milestone
Zcashd wallet replacement
Development

Successfully merging a pull request may close this issue.

Feature: Add an in-memory wallet backend framework zcash/librustzcash
3 participants
@pacu @str4d @oxarbitrage