Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add n5-zarr #54

Open
constantinpape opened this issue Jan 27, 2022 · 4 comments
Open

Add n5-zarr #54

constantinpape opened this issue Jan 27, 2022 · 4 comments

Comments

@constantinpape
Copy link
Collaborator

constantinpape commented Jan 27, 2022

It looks like there are still some issues with n5-zarr, see mobie/mobie-viewer-fiji#572. It would be good to include it here to figure this out systematically and then report the issues upstream.

@joshmoore
Copy link
Member

👍 for expanding, but n5-zarr written data is at least currently tested, no?

test/test_read_all.py::test_correct_read[read n5-java N5 using z5py, gzip] PASSED [ 70%]
test/test_read_all.py::test_correct_read[read n5-java N5 using z5py, raw] PASSED [ 70%]
test/test_read_all.py::test_correct_read[read n5-java N5 using pyn5, bzip2] PASSED [ 71%]
test/test_read_all.py::test_correct_read[read n5-java N5 using pyn5, gzip] PASSED [ 71%]
test/test_read_all.py::test_correct_read[read n5-java N5 using pyn5, raw] PASSED [ 72%]
test/test_read_all.py::test_correct_read[read n5-java N5 using zarr, gzip] PASSED [ 72%]
test/test_read_all.py::test_correct_read[read n5-java N5 using zarr, raw] PASSED [ 73%]

https://github.com/zarr-developers/zarr_implementations/runs/4895966219?check_suite_focus=true#step:5:374

@constantinpape
Copy link
Collaborator Author

The tests you are referring to are testing whether n5 data format written by n5-java can be read with other libraries supporting n5 data format. (And indeed it would be good to extend these tests to make sure it can read zarr written by the other libraries).

But we don't have any tests yet to check whether zarr data format written by n5-zarr (which uses n5-java) can be read by other libraries supporting zarr data format (and I have reasons to believe that there are some issues, see above). Conversely adding tests that read zarr data format with n5-zarr would also be good.

@joshmoore
Copy link
Member

Ah! Of course. Thanks for the clarification, @constantinpape. That might be as easy as a flag to the n5-java command. 👍

@jakirkham
Copy link
Member

Agree this would be good to add. Thanks for raising Constantin! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants