Bump c-blosc to 1.20.1 #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently failing due to Blosc/c-blosc#295 "Only allow external snappy support" |
joshmoore
force-pushed
the
blosc-bump
branch
from
16b71df to
d45c149
Compare
joshmoore
force-pushed
the
blosc-bump
branch
from
ade3b31 to
84909f1
Compare
|
Ok. Looks like blosc sans snappy builds fine. See eb859af for the tests that needed temporarily disabling which led to the coveralls failure. Feedback at this point would be appreciated. Is the best path forward installing snappy in all of our builds in order to have it enabled by default? Will the wheels discussed in #70 simplify things? |
|
Based on today's call, closing this in favor of blosc wheels. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt bumping c-blosc to fix OSX builds. See #258 (comment) from @avalentino