Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patchkit #71

Open
f0rki opened this issue Aug 13, 2016 · 2 comments
Open

add patchkit #71

f0rki opened this issue Aug 13, 2016 · 2 comments
Labels

Comments

@f0rki
Copy link
Contributor

f0rki commented Aug 13, 2016

https://github.com/lunixbochs/patchkit

Problem is it depends on the keystone, capstone, unicorn triad all from git. Should we install those generically and set LD_LIBRARY_PATH so that all other tools can use it, or keep it just to the patchkit subdir?

@zardus
Copy link
Owner

zardus commented Aug 13, 2016

For now, I think we should have everything installed in the patchkit subdir. I realize this leads to a lot of duplication, but I feel we should avoid building any sort of dependency resolution past what we do with install-root.

@f0rki
Copy link
Contributor Author

f0rki commented Aug 13, 2016

Basically that's what I was also thinking. As soon as we add that, we could also use a full blown package manager...

Since we have only one python virtualenv it's hard to isolate everything. If we want to use patchkit from within the virtualenv, we also somehow teach the whole virtualenv on how to load the libs. This could break things. I'm pretty sure we pull capstone in at some point via pip. I can see the appeal of static linking now...

I'll try to get it working as subdir-contained as possible.

@zardus zardus added the new tool label Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants