Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gpu): add debug/release modes #1483

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

pdroalves
Copy link
Contributor

@pdroalves pdroalves commented Aug 20, 2024

Introduces a cmake flag, CMAKE_BUILD_TYPE, to compile in Release mode (-O3) or not (-O0 -G -g).

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/570

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@pdroalves pdroalves requested a review from agnesLeroy August 20, 2024 21:05
@cla-bot cla-bot bot added the cla-signed label Aug 20, 2024
@pdroalves pdroalves force-pushed the pa/chore/compilationmode branch from fb64b3e to d11b20b Compare August 20, 2024 21:15
@pdroalves pdroalves force-pushed the pa/chore/compilationmode branch 2 times, most recently from a1a01b2 to 3af8d22 Compare September 5, 2024 13:12
@pdroalves pdroalves force-pushed the pa/chore/compilationmode branch from 3af8d22 to 039334d Compare September 6, 2024 14:31
@zama-bot zama-bot removed the approved label Sep 6, 2024
@agnesLeroy agnesLeroy merged commit 39c424b into main Sep 9, 2024
32 checks passed
@agnesLeroy agnesLeroy deleted the pa/chore/compilationmode branch September 9, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants