Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the upgradeProxy tasks to be compatible with Linux #183

Closed
jatZama opened this issue Dec 10, 2024 · 3 comments
Closed

Fix the upgradeProxy tasks to be compatible with Linux #183

jatZama opened this issue Dec 10, 2024 · 3 comments
Assignees

Comments

@jatZama
Copy link
Member

jatZama commented Dec 10, 2024

We noticed formatting error for the newImplem and currentImplem variables on Linux machine when doing the upgrade of GatewayContract with @stongo today. We had to manually append :GatewayContract to both of those, otherwise the upgrade task would fail.

@jatZama jatZama self-assigned this Dec 10, 2024
@stongo
Copy link

stongo commented Jan 6, 2025

@jatZama is there an update on this? we will be redeploying the coproc smart contracts for StableTestnet soon, and I anticipate contract upgrades will be required this quarter.

@jatZama
Copy link
Member Author

jatZama commented Jan 7, 2025

@stongo I redid the whole deployment + verification + upgrade flow on a linux VM running in AWS today and I was unable to reproduce the bug dicsussed in this issue. The upgrade worked seamlessly from first try, without changing anything from the upgrade task.
Note however that I used the new deployment flow which does not rely on the initial nonce of the deployer anymore, from this PR: #233
Maybe we should close this issue then?

@immortal-tofu
Copy link
Collaborator

Let's close it, we'll reopen it if we encounter the issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants