Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

Updates Webpack to v2 and updates corresponding dependencies #563

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frometor
Copy link
Contributor

incremental migration of Zappr from Webpack version 1 to version 2. Updates dependencies and reduces vulnerabilities. part of #543

@frometor frometor force-pushed the update-webpack-v2-and-dependencies branch from 470f53c to d223eda Compare January 28, 2019 18:43
@fokusferit
Copy link
Contributor

@frometor do you need some help?
Ci says:

BREAKING CHANGE: It's no longer allowed to omit the '-loader' suffix when using loaders.
                 You need to specify 'null-loader' instead of 'null'. 

so I guess some integration work is necessary? I hope that it is not related to some webpack conf inside a dependency ^^

@frometor
Copy link
Contributor Author

frometor commented Feb 7, 2019

@fokusferit I know. I am pretty sure it is part of a webpack conf inside an outdated dependency.
webpack.server.js:

/**
 * Externalize node_modules.
 */
const nodeModules = () => (
  fs.readdirSync('node_modules').
  filter(x => ['.bin'].indexOf(x) === -1).
  reduce((modules, m) => {
    modules[m] = 'commonjs2 ' + m;
    return modules
  }, {
    'react-dom/server': 'commonjs2 react-dom/server'
  })
)

@fokusferit fokusferit closed this Apr 9, 2019
@fokusferit fokusferit reopened this Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants