This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

False "approved" pull request #499

Closed

Dmitry-Erokhin opened this issue Mar 9, 2017 · 1 comment

Dmitry-Erokhin commented Mar 9, 2017

Repository zappr config requires 2 approvers.

Two PRs createrd to merge branch F(eature) to branches R(elease) and M(aster).

PR F->R approved by two guys and was merged
PR F->M was approved only by one guy but it show as approved by two and can be merged.

See screenshots.

Contributor

prayerslayer commented Mar 9, 2017

See also #465. Since you approve a commit id and not a diff, this is expected behavior.

prayerslayer closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.