Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use client-go directly instead of shelling out to kubectl #48

Open
aermakov-zalando opened this issue Jun 4, 2018 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@aermakov-zalando
Copy link
Contributor

aermakov-zalando commented Jun 4, 2018

Currently we call kubectl externally when applying manifests. This allows us to reuse apply logic, which would be cumbersome to implement internally, but leads to excessive resource consumption and complicates result handling (we have to capture the whole output and look for strings inside just to figure out if the error was because of a missing resource).
We should instead reuse the client instance we already have, especially considering that apply contains a lot of logic that we might not want anyway.

@aermakov-zalando aermakov-zalando added the enhancement New feature or request label Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant