From 76138005f7227fe51ea86a42c619ab8794110c91 Mon Sep 17 00:00:00 2001
From: Zak Henry <zak@cloudnc.com>
Date: Sun, 7 Jul 2019 17:30:26 +0100
Subject: [PATCH] feat(Language Support): Add support for json and json5

Closes #14
---
 README.md          |  4 +++-
 src/embedme.lib.ts |  6 ++++++
 test/fixture.md    | 26 ++++++++++++++++++++++++++
 test/sample.json   |  3 +++
 4 files changed, 38 insertions(+), 1 deletion(-)
 create mode 100644 test/sample.json

diff --git a/README.md b/README.md
index 97da94b..f962a55 100644
--- a/README.md
+++ b/README.md
@@ -78,7 +78,7 @@ Here's a list of file types supported by this utility, if you have a need for an
 contribute, it is easy!
 
 ```ts
-// src/embedme.lib.ts#L44-L68
+// src/embedme.lib.ts#L44-L70
 
 enum SupportedFileType {
   PLAIN_TEXT = 'txt',
@@ -93,6 +93,8 @@ enum SupportedFileType {
   XML = 'xml',
   MARKDOWN = 'md',
   YAML = 'yaml',
+  JSON = 'json',
+  JSON_5 = 'json5',
   PYTHON = 'py',
   BASH = 'bash',
   SHELL = 'sh',
diff --git a/src/embedme.lib.ts b/src/embedme.lib.ts
index 4236346..da4d0e7 100644
--- a/src/embedme.lib.ts
+++ b/src/embedme.lib.ts
@@ -54,6 +54,8 @@ enum SupportedFileType {
   XML = 'xml',
   MARKDOWN = 'md',
   YAML = 'yaml',
+  JSON = 'json',
+  JSON_5 = 'json5',
   PYTHON = 'py',
   BASH = 'bash',
   SHELL = 'sh',
@@ -68,12 +70,14 @@ enum SupportedFileType {
 }
 
 enum CommentFamily {
+  NONE, // some languages do not support comments, e.g. JSON
   C,
   XML,
   HASH,
 }
 
 const languageMap: Record<CommentFamily, SupportedFileType[]> = {
+  [CommentFamily.NONE]: [SupportedFileType.JSON],
   [CommentFamily.C]: [
     SupportedFileType.PLAIN_TEXT, // this is a lie, but we gotta pick something
     SupportedFileType.C,
@@ -90,6 +94,7 @@ const languageMap: Record<CommentFamily, SupportedFileType[]> = {
     SupportedFileType.SWIFT,
     SupportedFileType.KOTLIN,
     SupportedFileType.SCALA,
+    SupportedFileType.JSON_5,
   ],
   [CommentFamily.XML]: [SupportedFileType.HTML, SupportedFileType.MARKDOWN, SupportedFileType.XML],
   [CommentFamily.HASH]: [
@@ -102,6 +107,7 @@ const languageMap: Record<CommentFamily, SupportedFileType[]> = {
 };
 
 const filetypeCommentReaders: Record<CommentFamily, FilenameFromCommentReader> = {
+  [CommentFamily.NONE]: _ => null,
   [CommentFamily.C]: line => {
     const match = line.match(/\/\/\s?(\S*?$)/m);
     if (!match) {
diff --git a/test/fixture.md b/test/fixture.md
index 5efc3b4..9903717 100644
--- a/test/fixture.md
+++ b/test/fixture.md
@@ -228,6 +228,26 @@ hello:
   - world
 ```
 
+JSON
+
+<!-- embedme sample.json -->
+
+```json
+{
+  "hello": "world"
+}
+```
+
+JSON5
+
+```json5
+// sample.json
+
+{
+  hello: 'world',
+}
+```
+
 Ruby
 
 ```rb
@@ -371,3 +391,9 @@ Ignored block
 ```ts
 // sample.ts#L1-2
 ```
+
+### missing comment on language embed with no comment support
+
+```json
+
+```
diff --git a/test/sample.json b/test/sample.json
new file mode 100644
index 0000000..f2a886f
--- /dev/null
+++ b/test/sample.json
@@ -0,0 +1,3 @@
+{
+  "hello": "world"
+}