Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion on default font size ; playing nice with dark theme #21

Open
orionlee opened this issue Jul 2, 2021 · 2 comments
Open

Suggestion on default font size ; playing nice with dark theme #21

orionlee opened this issue Jul 2, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@orionlee
Copy link

orionlee commented Jul 2, 2021

Two separate UI issues, but potential fixes are loosely related so I group them together.

  1. The default font size seems to be a bit too large.
  2. When Visual Studio Code is in a dark theme, the font color is not switched to light color.

image

For font size, it could be helpful if it can be specified by users. Another option is to obey Visual Studio Code's default size.


Suggested solution:

One way is to tweak the css:

/* fix font family */
.vditor .vditor-reset {
font-family: var(--vscode-editor-font-family)!important;
}

If we add the following to the css rule, it'll make the editor area use vscode' default color / font size (rather than the hardcode value in .vditor style)

    font-size: var(--vscode-font-size, var(--theme-font-size));
    color: var(--vscode-editor-foreground, var(--theme-foreground));    

With the css change, it looks like:

image

@zaaack zaaack added the enhancement New feature or request label Jul 6, 2021
@jamesoflol
Copy link

Yeah the font is quite large for me - macos

@maolike
Copy link

maolike commented Jan 12, 2022

大佬 快点改了发个版本呀 @zaaack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants