Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid birthday Years can be added #3

Open
yyyaohhh opened this issue Nov 17, 2023 · 1 comment
Open

Invalid birthday Years can be added #3

yyyaohhh opened this issue Nov 17, 2023 · 1 comment

Comments

@yyyaohhh
Copy link
Owner

yyyaohhh commented Nov 17, 2023

Allows birthdays with invalid years to be added. User Guide and Developer guide only mentioned invalid dates in planned enhancements but did not mention about checking for valid years.

image.png

image.png

@nus-pe-script
Copy link

nus-pe-script commented Nov 20, 2023

Team's Response

Thanks for bringing this up! We feel that this is not significant enough of an issue to fix, since realistically, ED doctors would not purposely input a weird year when adding/editing a patient. Moreover, if we were to restrict the birth years, we would be concerned about how to draw a line on the range of accepted years. Nonetheless, this would be an issue that would be fixed with point 6 of our Planned Enhancements since dates can include years too.

image.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: > ED doctors would not purposely input a weird year when adding/editing a patient.

In case of emergency situations, I believe that most people, even ED doctors would make careless mistakes or input the wrong year, and especially they are nervous or tired after a whole day's focus or attention. Therefore I find this very necessary.

Nonetheless, this would be an issue that would be fixed with point 6 of our Planned Enhancements since dates can include years too.

It is also quite unreasonable for the team to only include invalid dates but not invalid years in their planned enhancements, or maybe they did not manage to find this bug during their own testing.

Moreover, if we were to restrict the birth years, we would be concerned about how to draw a line on the range of accepted years.

I believe that they can easily at least draw a line and limit it to 130 years, since the record of the age of the oldest person on earth is 122 years. I believe that unreasonable years like 1000 should definitely not be allowed.

Furthermore, this is used for calculating the age of a patient and displayed in the list. One of the existing sorting features, sort age, heavily relies on this. Thus, it is essential to ensure that birth years are more valid.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants