Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why is it not possible to use Context from hono in getLoadContext ? #23

Closed
ogadra opened this issue Nov 17, 2024 · 2 comments · Fixed by #24
Closed

Question: Why is it not possible to use Context from hono in getLoadContext ? #23

ogadra opened this issue Nov 17, 2024 · 2 comments · Fixed by #24

Comments

@ogadra
Copy link
Contributor

ogadra commented Nov 17, 2024

I reviewed the createGetLoadContextArgs function in src/remix.ts.
It creates the argument for getLoadContext using hono's context.
I believe it would be more practical if the argument of the getLoadContext function were directly hono's context. That way, we could leverage Hono's middleware in Remix.
However, this is not how it works in practice. I assume there must be a reason for this. Could you explain why?

@yusukebe
Copy link
Owner

Could you explain why?

There is no reason. Just not implemented, but like this? #24

@ogadra
Copy link
Contributor Author

ogadra commented Nov 19, 2024

Thanks. I'll check it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants