Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for react-router v7 #20

Open
barakcodes opened this issue Nov 11, 2024 · 2 comments
Open

Support for react-router v7 #20

barakcodes opened this issue Nov 11, 2024 · 2 comments

Comments

@barakcodes
Copy link
Contributor

Thank you for the awesome package.

Is there any plan for supporting react-router v7, once that is out? Since it's a different package name, not sure
which route will be better keeping the current package and maybe a new package specifically for react maybe hono-react-router-adapter or something else.

I tried to make it work with the workers template, it didn't take too much work but nothing has been tested substantially just that it builds and runs.
https://github.com/barakcodes/hono-remix-adapter/tree/react-router-only

@barakcodes
Copy link
Contributor Author

Waiting for this PR to be merged sergiodxa/remix-hono#297, wondering if it makes more sense to drop it as a dependency and move the routing adapter and staticAssets code to this plugin(it's not too much code) and routing adapter is already part of the codebase.

@yusukebe
Copy link
Owner

#33 is related to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants