Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Use Apache Beam 2.42.0 #51

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

UsaMomokawa
Copy link
Contributor

@UsaMomokawa UsaMomokawa commented Oct 19, 2022

Summary

The current latest version, kuromoji-for-bigquery 0.3.0 uses Beam 2.34.0.
However, Beam 2.34.0 will be deprecated on November 11, 2022.

This pull request updates the Apache Beam version to 2.42.0. (latest version)
I updated version of kuromoji-for-bigquery to 0.4.0, as the minor version seems to change depending on the version of Beam used.


I found that kuromoji 0.7.7 is no longer provided.
So this pull request adds kuromoji 0.7.7 built from source code.

@UsaMomokawa UsaMomokawa marked this pull request as ready for review October 19, 2022 02:24
@UsaMomokawa UsaMomokawa requested a review from yu-iskw as a code owner October 19, 2022 02:24
@UsaMomokawa UsaMomokawa marked this pull request as draft October 19, 2022 02:30
@UsaMomokawa
Copy link
Contributor Author

I found that kuromoji 0.7.7 is no longer provided.
https://mvnrepository.com/artifact/org.atilika.kuromoji/kuromoji/0.7.7

@UsaMomokawa
Copy link
Contributor Author

UsaMomokawa commented Oct 21, 2022

95397f9

I understand that We need to upgrade kuromoji. #9
For the time being, I would like to refer to kuromoji 0.7.7 built from source code.

Let me know your thoughts.

@UsaMomokawa UsaMomokawa marked this pull request as ready for review October 21, 2022 08:36
Copy link
Owner

@yu-iskw yu-iskw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UsaMomokawa Thank you for the first contribution. LGTM.

@yu-iskw yu-iskw merged commit 9be85b1 into yu-iskw:master Oct 26, 2022
@yu-iskw
Copy link
Owner

yu-iskw commented Oct 26, 2022

I will release a new version later after checking if there is urgent vulnerability we have to fix or not.

@yu-iskw
Copy link
Owner

yu-iskw commented Oct 26, 2022

I have just released 0.4.0. Please make sure of it.

https://github.com/yu-iskw/kuromoji-for-bigquery/releases/tag/0.4.0

@UsaMomokawa
Copy link
Contributor Author

@yu-iskw Thank you so much.

@UsaMomokawa UsaMomokawa deleted the update-beam-2.42.0 branch October 26, 2022 02:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants