Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails6 compatibility #15

Open
fwolfst opened this issue Feb 24, 2020 · 2 comments
Open

Rails6 compatibility #15

fwolfst opened this issue Feb 24, 2020 · 2 comments

Comments

@fwolfst
Copy link
Contributor

fwolfst commented Feb 24, 2020

In Rails6 the signature for TemplateHandlers apparently changed.

#call now requires two arguments (template and source). I will PR an easy fix, but do not know how to keep backwards compatibility (other template handler implementations should have done that, though).

@fwolfst
Copy link
Contributor Author

fwolfst commented Feb 24, 2020

Problem seemed to be a redcarpet dependency. I had redcarpet 3.5 which apparently is only compatible with emd 0.1 .

I propose:

  • check and relax the redcarpet dependency in gemspec ( '~> 3') or
  • state the versions explicitely in README:
    gem 'emd', '~> 0.5'
    gem 'redcarpet', '~> 3.4'

@fwolfst
Copy link
Contributor Author

fwolfst commented Feb 24, 2020

Again summarized: The fixes in 0.5.0 (#13) work for me, but bundle and bundle update did not fetch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant