Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to build all #191

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Attempt to build all #191

wants to merge 2 commits into from

Conversation

hannesa2
Copy link
Collaborator

@hannesa2 hannesa2 commented Sep 6, 2020

I tried to build all, but I miss files prjMakefilesGenerator.*

Btw, I started to support macOS

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Sep 6, 2020

But to be honest, to build all is currently a miracle to me

@hannesa2 hannesa2 force-pushed the InvestigateBuildAll branch 3 times, most recently from 943e547 to 3d4963a Compare September 7, 2020 10:56
@topherbuckley
Copy link
Contributor

Oh so you are starting to work on these! I haven't touched these at all yet. So I'm curious with the structural changes, what IDE are you using? Something that makes working with bash, c, etc. all easier? I assumed you were using Android Studio up to this point, which is what led me to my final questions in that thread.

So what do you need help on in here exactly? Are you running on MacOS? I have a machine here that I could use, but I'd likely just be relying on the runners unless there was some more rigorous testing needed for some reason.

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Sep 9, 2020

So I'm curious with the structural changes,

There is no change here at all

So I'm curious with the structural changes,

Android Studio, but you can use any Intellij IDE

The main question is: Where are the missing files ?

@topherbuckley
Copy link
Contributor

The main question is: Where are the missing files ?

As you pushed this and all checks passed, I assume you figured this out?

@hannesa2
Copy link
Collaborator Author

Look, everything it there

https://jitpack.io/#ytai/ioio/6.0.0

image

@hannesa2
Copy link
Collaborator Author

@topherbuckley
Copy link
Contributor

Yep, looks great!

Everything you needed to generate the JARs and upload to jitpack is included in this PR (i.e. only in tools/make-all)? Or were the changes to some build.gradle files that allowed you to generate the JARs in addition to the AARs?

@hannesa2
Copy link
Collaborator Author

This tools/xxx.sh is not touched and used till now.
Because it's simply not working, pls see my first post #191 (comment)

@topherbuckley
Copy link
Contributor

Is there a reason this wasn't run on the jitpack 6.2.0? I'm only seeing the Android specific libs there. (i.e. no IOIOLibCore)

https://jitpack.io/#ytai/ioio/6.2.0

@hannesa2
Copy link
Collaborator Author

Is there a reason this wasn't run on the jitpack 6.2.0? I'm only seeing the Android specific libs there. (i.e. no IOIOLibCore)

https://jitpack.io/#ytai/ioio/6.2.0

That's a bug. The question is where ?
On the release page all is there https://github.com/ytai/ioio/releases/tag/6.2.0
Only jitpack.io runs into this issue

@topherbuckley
Copy link
Contributor

Huh, ok. Thanks for clarifying. I didn't notice it built in the release page. I don't really need this immediately, so may not work on this for a while, but just wanted to note that the sample apps HelloIOIO and HelloIOIOService (among others I presume) depend on IOIOLibCore, so I'm not sure the current README with reference to $LATEST pointing to "6.2.0" is entirely accurate as it does not pull in IOIOLibCore, and thus one cannot build any app that controls the IOIO Board. For the moment I've reverted to "6.1.0" in my tests.

@hannesa2
Copy link
Collaborator Author

I found the reason it's #251
Any help is welcome to fix it

@topherbuckley
Copy link
Contributor

I found the reason it's #251
Any help is welcome to fix it

I'm not seeing the link between this and jitpack. Did you see a build error that references this change? Can you link to the build error if so? Does jitpack depend on the maven plugin and doesn't work with the maven-publish plugin?

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Aug 2, 2021

With apply plugin: 'maven-publish' it stops to build the jar's. This is the link

@hannesa2 hannesa2 force-pushed the InvestigateBuildAll branch 2 times, most recently from 7c6d98a to 83b10a5 Compare June 7, 2024 07:24
@hannesa2
Copy link
Collaborator Author

hannesa2 commented Jun 7, 2024

It looks like nbproject/Makefile-variables.mk is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants