Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: use numpy.testing.overrides API for NEP 18/35 completion tests #526

Open
neutrinoceros opened this issue Oct 10, 2024 · 1 comment
Open
Milestone

Comments

@neutrinoceros
Copy link
Member

I'm working on expanding the definition of array_functions as retrieve by the numpy.testing API, to include NEP 35 functions
numpy/numpy#27490

I anticipate this will break completion tests in unyt. Implementing NEP 35 is a large task (#518) that I reserve for the next feature release, but I'd like to make unyt's test suite future-proof before that, by explicitely listing those functions as not implemented in uny 3.0.4

@neutrinoceros neutrinoceros added this to the 3.0.4 milestone Oct 10, 2024
@neutrinoceros
Copy link
Member Author

turns out we're not using numpy.testing.overrides.get_overridable_numpy_array_functions yet, so this is actually a non issue for unyt 3.0.4.
Nonetheless, we should be using this API for our completion tests, so I'll re-purpose this issue for unyt 3.1.0

@neutrinoceros neutrinoceros modified the milestones: 3.0.4, 3.1.0 Oct 10, 2024
@neutrinoceros neutrinoceros changed the title TST: NEP 18 completion test will fail on NumPy 2.2 TST: use numpy.testing.overrides API for NEP 18/35 completion tests Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant