Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #829

Open
ysong10 opened this issue Nov 18, 2020 · 0 comments
Open

test #829

ysong10 opened this issue Nov 18, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ysong10
Copy link
Owner

ysong10 commented Nov 18, 2020

The current $http cache takes only the url as key. Consider the case where a call to the API uses the 'Range' header for pagination and cache is set to true. All requests to the same url with different pagination will return the first cached response to the inital page. IMHO headers are a defining part of the request, just like the url, and should therefore be included in the cache key.

Are there plans to include this? Would you accept a pull request?

@bee-tool bee-tool bot added the enhancement New feature or request label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant