Animation part 4: Presets #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just hardcoded numbers. Now they can be defined with expressions just like start and end. Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
yshui
force-pushed
the
animation-presets
branch
3 times, most recently
from
4273e32
to
1f2633b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1305 +/- ##
==========================================
+ Coverage 52.85% 54.33% +1.48%
==========================================
Files 64 70 +6
Lines 14019 14868 +849
==========================================
+ Hits 7410 8079 +669
- Misses 6609 6789 +180
|
yshui
force-pushed
the
animation-presets
branch
3 times, most recently
from
ef23930
to
8555a0f
Compare
Add a tool to generate C function from a compiled animation script. The generated function will reproduce the animation script when called. The goal is to implement animation presets. Instead of creating strings and then compile them into scripts, by using these generated function, we can skip the parsing step and create compiled scripts directly. Placeholders are supported in the preset script, so some configurability still exists even when using presets. Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
yshui
force-pushed
the
animation-presets
branch
from
8555a0f
to
25cd7f7
Compare
Support multiple choice parameters in additional to plain old numbers. With this we are now able to change the direction of sliding, yippee! Signed-off-by: Yuxuan Shui <[email protected]>
yshui
force-pushed
the
animation-presets
branch
2 times, most recently
from
b3cd24c
to
d502e1b
Compare
Signed-off-by: Yuxuan Shui <[email protected]>
yshui
force-pushed
the
animation-presets
branch
from
d502e1b
to
5db4192
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now use preset animations, like this:
Related: #862