Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading django-oauth-toolkit to 1.5 and above #49

Closed
stuart-bradley opened this issue May 2, 2023 · 2 comments
Closed

Upgrading django-oauth-toolkit to 1.5 and above #49

stuart-bradley opened this issue May 2, 2023 · 2 comments

Comments

@stuart-bradley
Copy link
Contributor

In django-oauth-toolkit 1.5, there is a change to the AbstractGrant.redirect_uri which changes the field from a CharField to a TextField (link). This means that to support both 1.3 and 1.5+ we need to support two different migration paths in drf-integrations-framework.

Ideally, we should just have a hard cut-off at 1.5 to resolve the issue, but this we are currently supporting services using 1.3.2.

@stuart-bradley
Copy link
Contributor Author

When jumping to django-oauth-toolkit@2.* there are a number of non-backwards compatible changes:

  • Migrations that modify the abstract models.
  • Introduction of OAUTH2_PROVIDER_ID_TOKEN_MODEL and oauth_provider.IdModel.
  • Introduction of oauth2_provider.models.ClientSecretField
    Since non of this is in < 2.*, it is not likely possible to upgrade and maintain backwards compatibility between versions.

@stuart-bradley
Copy link
Contributor Author

Close via #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant