Skip to content
This repository has been archived by the owner on Apr 30, 2023. It is now read-only.

Secrets values revealed using actions_comment #25

Open
fulder opened this issue Nov 5, 2020 · 1 comment
Open

Secrets values revealed using actions_comment #25

fulder opened this issue Nov 5, 2020 · 1 comment

Comments

@fulder
Copy link

fulder commented Nov 5, 2020

GitHub secrets are automatically masked in the action logs, but setting action_comment to true for e.g. cdk synth prints the real secret values directly inside the PR comment.

This can be a security issue if someone uses a secret used in e.g. a lambda function env vars without realizing this will be automatically printed in a PR comment.

@cynicaljoy
Copy link

Not recommending this shouldn't be fixed (if it can) but just a word of caution: if you're putting secrets into environment variables in plain text then anybody with access to the Lambda is going to be able to read them.

It's recommended that you use either Secrets Manager or Parameter Store to keep the values truly secure.

https://aws.amazon.com/blogs/compute/sharing-secrets-with-aws-lambda-using-aws-systems-manager-parameter-store/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants