Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When clicking on a link is not going to the link #138

Closed
1 task done
Lfrancos opened this issue May 7, 2024 · 5 comments · Fixed by #209
Closed
1 task done

[BUG] When clicking on a link is not going to the link #138

Lfrancos opened this issue May 7, 2024 · 5 comments · Fixed by #209

Comments

@Lfrancos
Copy link

Lfrancos commented May 7, 2024

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Description

You can see that there are a lot of links in the preview but I'm not able to click to go to the link.

Steps to Reproduce

If you know the steps, follow the below format and provide steps to reproduce

For example:

  1. Go to the example page.
    2 scroll down
  2. When you see "Do you like it? Please star our repo in Github.
  3. You should be able to click on "Our repo in Github". But I'm not able to.

Environment

  • Windows 11:
  • Browser: Chrome

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

@maZahaca
Copy link
Collaborator

maZahaca commented May 7, 2024

Good example, I actually had the same question.
So, the editor shows you a way to change the link with the Link menu, but the link element is rendered without the ability to click it and follow the link.

image

@Nitin6404
Copy link

I would like to work on it

@maZahaca
Copy link
Collaborator

maZahaca commented May 7, 2024

@Nitin6404 Here is the dev community, feel free to join and get in touch with us.

@Darginec05
Copy link
Collaborator

Thanks for reporting! This is good point.
Links are working good when editor is read only, but it should work for edit mode also.
This is how I see the solution to this problem with a good approach to UX:

  1. When you hover over link in edit mode, something like a small button should be displayed over it
Screen Shot 2024-05-07 at 16 36 41
  1. So, when you click on edit it should show Link editor from @yoopta/link-tool package
Screen Shot 2024-05-07 at 16 39 47
  1. To access to Link editor from @yoopta/link-tool package (if it passed to props tools) we can use useTools hook

@Nitin6404 It would be great!
Currently we are working on documentation for contribution.
Join to our community - https://t.me/YooptaEditor

@Darginec05
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants